[geeklog-devel] SQL Server 2005 - MSSQL Driver

Tue May 6 11:41:16 EDT 2008

Hello Randy,

The complete abstraction is very much still in place! Thankfully I
haven't run in to anything that would cause me to break one for the
other. I'm hoping, now that I've fixed my CVS connection issues, that I
can get all the changes that took place merged together and finish up
the installer tomorrow.

I'm wondering your opinion on add/remove slashes. How structured are the
queries in that we could possibly rely on turning on quotes_sybase in
the mssql driver before queries start getting pumped out. If all the SQL
queries are using proper syntax (anything that uses double quotes needs
to be re-written anyway because it conflicts with SQL Server) this could
solve problem temporarily while the addslashes are phased out. You
probably have more experience with the Geeklog core than I, so I'm
hoping you can give me some good news here.

Also, in regard to MySQL....I think it is important to move that driver
to mysql improved (mysqli) and start slowly implementing
mysql_real_escape_string instead of addslashes, that way we can all work
together in creating a better abstraction layer, hopefully making it
extremely easy for anyone to drop in new support for other DBs any time!

Anyway, long story short, I hope that I can finish up the installer and
driver by tomorrow and send file + patches through to you all soon.
Should I be on the CVS mailer for that process?

Regards,

Kevin Peno

From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Randy
Kolenko
Sent: Monday, May 05, 2008 4:17 PM
To: Geeklog Development
Subject: Re: [geeklog-devel] SQL Server 2005 - MSSQL Driver

This is good news that we've got some new eyes in the mix.  

Some Background: my initial intent and primary goal was to write the
abstraction class for MSSQL to minimize the number of code changes
required in Geeklog and to hopefully have as many existing plugins be
easily converted to support MSSQL.  That objective was at least
relatively successfully accomplished!  One of the reasons the initial
class looks the way it does was to handle the "uniqueness" of the
Geeklog original code base.  That includes using the horriffic "replace
into" and LIMIT without even mentioning the various
add/remove/add/remove/remove/add/remove slashes :-)

However there were always a variety of issues I wanted to resolve in the
original MSSQL code -- and with very little MSSQL based feedback, it was
tough to get enough issues presented to even have enough to go on for a
rewrite.

I would love to see the new abstraction class and associated install
script.  Can you please post them here on the list?

My next question is:  with the changes you've made, how does that affect
the MySQL support?  You can't break one to favour the other and nor will
anyone adopt massive code changes for their existing and popular MySQL
plugins to support mssql.

-randy

	-----Original Message-----
	From: Kevin J. Peno [mailto:kevin at metalaxe.com] 
	Sent: Sunday, May 04, 2008 4:58 PM
	To: geeklog-devel at lists.geeklog.net
	Subject: [geeklog-devel] SQL Server 2005 - MSSQL Driver

	Hello,

	My name is Kevin Peno. I work with the Microsoft Open Source
Group and have been assigned to help with updating this software to work
properly with the new SQL Server driver from Microsoft. I've been
working on this for about 3 weeks now and have completely re-written the
your abstraction file to work with the new driver, as well as cleaned up
a good amount of the code, SQL batch for the install. Currently I'm at
the point of fixing some issues with addslashes spread throughout the
code that is causing a lot of compatibility issues. I haven't been able
to get a CVS system working well yet, so I'm unable to commit, but
hopefully that will be resolved soon so that you can all take a look and
do some testing.

	Today I'm emailing because I have been watching the mailing list
and noticed increased activity on the subject. Because I haven't been
able to use an CVS client I'm stuck manually patching against nightly
builds for now, which is making it extremely difficult for me to keep up
with the changes being made (much less know the difference between what
I fixed and you all have fixed. I was hoping that we could maybe sync
testing/changes with each other in a better way temporarily, such as
emailing me udiffs directly if changes are made.

	If you guys have any ideas that will help me out with this
temporary inconvenience, such as workarounds for problems with any
windows CVS client. I'd really appreciate it. I hope that I can get
everything finished upo, reviewed and released to you fro testing within
the next 1.5 weeks.

	Regards,

	Kevin Peno

	Senior PHP Developer

	Microsoft Open Source Group

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist8.pair.net/pipermail/geeklog-devel/attachments/20080506/7c267eee/attachment.html>