[geeklog-devel] Fwd: Geeklog Comments

[Tom]

I had thought of using PLG_getItemInfo for this but as you said it needs
modification (which I am not against), and since it deals specifically with
comments and the What's new block, and I don't see this type of information
being needed by anything else, I didn't think PLG_getItemInfo was the spot
to put this functionality.

I could also just reuse PLG_getWhatsNew and add a flag to it to return just
comment information. This may be the best route actually.

Tom

-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Joe Mucchiello
Sent: February-21-10 3:14 PM
To: Geeklog Development
Subject: Re: [geeklog-devel] Fwd: Geeklog Comments

I'm confused. Isn't this what the PLG_getItemInfo is for? The what's 
new block should take the type and sid info from the comments table 
and query the plugin for the item's title. This eliminates all 
permissions and status problems completely.

Perhaps, you might modify PLG_getItemInfo so that $id could be an 
array of ids (or create a PLG_getItemSinfo if you don't want to 
change the interface) so the plugin could optimize the SQL required. 
But that is a different issue. I'd hate to see another plugin api for 
the what's new block.

At 02:36 PM 2/21/2010, you wrote:
>Forwarding this to the list to get some feedback from plugin authors.
>This is about getting plugin comments into the What's New block,
>http://project.geeklog.net/tracking/view.php?id=835
>
>My gut feeling seems to advise against relying on SQL provided by the
>plugin. But the alternative would require more work in the plugins.
>
>---------------- Anfang Weiterleitung ----------------
>Betreff: Geeklog Comments
>Gesendet: Samstag, 20. Februar 2010 13:56 Uhr
>Von: Tom <websitemaster at cogeco.net>
>An: 'Dirk Haun' <dirk at haun-online.de>
>
>Hey Dirk,
>
>I have been looking at the What's New Block to add comment support for more
>than just Stories.
>
>Returning the newest comments for plugins is easy but then you start to run
>into problems when handling things like, what table do you use to access
the
>parent item, permissions of the parent item or any other status variables
>(similar to the draft flag for stories).
>
>I think the best approach would be to create a new plugin api for this
>called PLG_getWhatsNewComment

----
Joe Mucchiello
Throwing Dice Games
http://www.throwingdice.com 

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel

__________ Information from ESET NOD32 Antivirus, version of virus signature
database 4885 (20100221) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com



 

__________ Information from ESET NOD32 Antivirus, version of virus signature
database 4886 (20100222) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com