[geeklog-devel] Geeklog Feeds and how they are suppose to work?

[Tom]

>> Is that not what it's doing now? When you edit, say, a calendar entry (as
an admin), COM_rdfUpToDateCheck('calendar') is called and only the calendar
feeds are updated. That the 'calendar' bit is passed down to the plugin is
really just redundant information, I think.

No that is not what it is doing. If you pass a type it does nothing but pass
it to all the plugins that have a feed. plugin_feedupdatecheck_xxx is run
for every plugin regardless of what type is passed.

So I will change the function to if a type is passed just run the feed(s)
for that plugin.

>> The idea was probably that you really only need to publish a "future"
article if someone is actually looking at the list of articles - and so you
only need to update the feed when that happens.

Yeah I realize that and I guess it still makes sense since I assume some
people must post a "future" article.

What I plan to do is move the call to COM_rdfUpToDateCheck to lib_common but
it will only run for articles if it needs too. I will store in Geeklog Var
table the date/time of the lastest story that has been publish. If a quick
check of this compared to the article table fails then COM_rdfUpToDateCheck
will run for the articles and then the var table will be updated. When an
article is saved/updated/deleted I will have to add an update to the var
table as well.

I do not plan to run it for other plugins in lib-common. Plugins can take
care of that themselves. :-)

If that makes sense then I will go ahead and update the code.

Tom

-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun
Sent: October-06-12 1:02 PM
To: Geeklog Development
Subject: Re: [geeklog-devel] Geeklog Feeds and how they are suppose to work?

Tom wrote:

> 1) Currently COM_rdfUpToDateCheck is being called in index.php where 
> someone is likely viewing the homepage or topics. I am not sure why 
> this was put here since a feed can change and it doesn't matter if a 
> user views a topic or not. The updated smarter call to this should be
moved to lib-common.

The idea was probably that you really only need to publish a "future"
article if someone is actually looking at the list of articles - and so you
only need to update the feed when that happens.

Not sure if that makes sense any more. However, moving the call to
lib-common.php would obviously put even more load on the server since the
check would then be run for every call to Geeklog, no matter what the
current user is doing.


> 2) You can pass an updated type to COM_rdfUpToDateCheck, for example 
> 'calendar' like so.
> 
> COM_rdfUpToDateCheck('calendar', $event_type, $eid);
> 
> I assumed this would just update the calendar plugin feed but I am wrong.
> All it does is pass the variable to ALL the plugin functions 
> plugin_feedupdatecheck_xxx. The plugin function is supposed to then 
> use it (I am not sure how or why) because none of the core plugins or
forum does.

I think the type was really only used to figure out if we need to update all
the feeds or only the feeds of a specific plugin (see the check in
COM_rdfUpToDateCheck)


> Or should COM_rdfUpToDateCheck use $updated_type to update only the 
> correct plugin feeds?

Is that not what it's doing now? When you edit, say, a calendar entry (as an
admin), COM_rdfUpToDateCheck('calendar') is called and only the calendar
feeds are updated. That the 'calendar' bit is passed down to the plugin is
really just redundant information, I think.

bye, Dirk


--
http://www.themobilepresenter.com/

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel