[geeklog-devel] Contributing to a Github repository

[cordiste]

@Tom

For Owners

Open an issue for every bug or feature request and close it with via
commit message make sense
https://help.github.com/articles/closing-issues-via-commit-messages/

For others:

For any bug or feature request:
1. Create a New issue https://help.github.com/articles/creating-an-issue/
If you can solve the bug
2. Edit the file and propose file change
https://help.github.com/articles/editing-files-in-another-user-s-repository/


For contribution and new features to a plugin:
1. Fork it
2.Create your feature branch (git checkout -b my-new-feature)
3. Commit your changes (git commit -am 'Add some feature')
4. Push to the branch (git push origin my-new-feature)
5. Create new pull request

@ Ivy

Can you try the slack tool and tell us if we really need it? To much
tools can be difficult, and using the geeklog-devel mailing list is
cool :)

Ben

2016-01-20 16:23 GMT+01:00 Tom <websitemaster at cogeco.net>:
> Yes we do.
>
> Everyone I am pretty new to GitHub and I don't know all the right answers,
> so if I say anything that doesn't makes sense (or you know of a better way)
> let me know.
>
> For the Geeklog Plugins Community we have 4 organization owners (myself,
> mystralkk, dengen, and ben). That is enough for now.  We all have access to
> all the repositories. Any other people who wish to contribute to any current
> repository should contact one of the owners of the particular repository
> explain what they want to do and they can discuss how to do it (ie a fork,
> create a  team, or write access to repository, etc...). You never know what
> the owner of the repository has planned for the plugin so it is always best
> to discuss changes big or small with them and what your role maybe.
>
> Anyone who wants to add a new repository to Geeklog Plugins should contact
> one of the organizations owners and we can setup the new repository and give
> you full access to it.
>
> For us owners Ben since we have access to all repositories I still think if
> anyone of us (owners) want to make changes to someone else's plugin you
> should contact them first (especially if it is a big change) and discuss how
> to best accomplish the goal.
>
> I think any pull request (or fork) should have an issue attached to it to
> show if it is a bug fix or new feature. Us owners of repositories should
> also get better at adding what we are working on currently for a plugin.
> Either through some sort of Roadmap (using the GitHub wiki feature maybe)
> and added the feature we are working on in the repository issue tracker.
> This way people will have a better idea of what may be happening with the
> plugin. This also means added the required milestone version numbers and any
> labels.
>
> Regarding your pull request for the Gus plugin Ben, I missed seeing that and
> I approved the change.
>
> Thanks for finding the forum issues Ben. I haven't set up the new version
> numbers (in the code) for any of the plugins I am "in charge of" but you are
> more than welcome to commit any fixes you work on directly to master if you
> wish. Just make sure it has been tested well and it has an issue attached to
> it with a good description and appropriate labels.
>
> I had looked before where we can post this type of information about how to
> best contribute to the Geeklog Plugins Organization on GitHub (where people
> can find it) but the description for an organization can only contain a
> couple hundred characters. Maybe I need to create a page on Geeklog.net (or
> the Geeklog Wiki) about it and include the link in the description.
>
> Thoughts?
>
> Tom
>
>
> -----Original Message-----
> From: geeklog-devel [mailto:geeklog-devel-bounces at lists.geeklog.net] On
> Behalf Of cordiste
> Sent: Wednesday, January 20, 2016 7:54 AM
> To: Geeklog Development <geeklog-devel at lists.geeklog.net>
> Subject: Re: [geeklog-devel] Contributing to a Github repository
>
> Tom,
>
> As a Geeklog community member do I need to open an issue for a bug or
> enhancement in the Github repository or can I just commit my changes?
> And if I can commit directly, do I make it in the master branch or I need to
> create a new branch?
>
> For exemple:
>
> - Gus plugin I maked a pull request
> https://github.com/Geeklog-Plugins/gus/pull/2
>
> - Forum plugin I added some issues
> https://github.com/Geeklog-Plugins/forum/issues/created_by/hostellerie
>
> We really need to clarify how everybody contribute :)
>
> Ben
>
> 2016-01-20 13:07 GMT+01:00 Tom <websitemaster at cogeco.net>:
>> That is a good idea especially since we can't do patches anymore. (at
>> least like how we did before).
>>
>> I was also wanted to add a good practices page or something on our
>> wiki/readme explaining the best way to contribute, add issues, and
>> committing code. Here are a few help pages I have looked at so far.
>>
>> General Help
>> https://help.github.com/
>>
>> Glossary
>> https://help.github.com/articles/github-glossary/
>>
>>
>> Contributing (Pull Requests)
>> https://guides.github.com/activities/contributing-to-open-source/
>> https://guides.github.com/activities/forking/
>>
>> Commits
>> https://help.github.com/categories/commits/
>>
>> Guides
>> https://guides.github.com/
>>
>> https://help.github.com/categories/commits/
>>
>> Issue Guide
>> https://guides.github.com/features/issues/
>>
>> Markdown Guide
>> https://guides.github.com/features/mastering-markdown/
>> https://help.github.com/categories/writing-on-github/
>>
>>
>>
>> -----Original Message-----
>> From: geeklog-devel [mailto:geeklog-devel-bounces at lists.geeklog.net]
>> On Behalf Of cordiste
>> Sent: Wednesday, January 20, 2016 6:17 AM
>> To: Geeklog <geeklog-devel at lists.geeklog.net>
>> Subject: [geeklog-devel] Contributing to a Github repository
>>
>> Now that we are on Github, we must decide what is the best way for
>> people to contribute to code.
>>
>> It seems to be a good practice to add a CONTRIBUTING label in the
>> README.md file, so I propose the following steps based on the Github
>> documentation:
>>
>> 1. Fork the repository and clone it locally.
>> 2. Create a branch: your branch name should be descriptive, so that
>> others can see what is being worked on.
>> 3.Add commits to your branch: add, edit, or delete one or more files
>> and make tests 4.Open a Pull Request: by using GitHub's @mention
>> system in your Pull Request message, you can ask for feedback from
>> specific people or teams 5.Before merging we discuss and review your
>> code. The person or team reviewing your changes may have questions or
> comments.
>>
>> Thank you to modify and / or supplement this.
>>
>> Ben
>> _______________________________________________
>> geeklog-devel mailing list
>> geeklog-devel at lists.geeklog.net
>> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>>
>> _______________________________________________
>> geeklog-devel mailing list
>> geeklog-devel at lists.geeklog.net
>> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>